X-Git-Url: http://git.rohieb.name/openwrt.git/blobdiff_plain/06b8f376442456d4fe011c3090868864c041aed9..adde7768a2eab2950a7628319ec832c63a00ff03:/target/linux/adm5120/files/drivers/net/adm5120sw.c

diff --git a/target/linux/adm5120/files/drivers/net/adm5120sw.c b/target/linux/adm5120/files/drivers/net/adm5120sw.c
index 877542699..8f3610e90 100644
--- a/target/linux/adm5120/files/drivers/net/adm5120sw.c
+++ b/target/linux/adm5120/files/drivers/net/adm5120sw.c
@@ -1,7 +1,7 @@
 /*
  *  ADM5120 built-in ethernet switch driver
  *
- *  Copyright (C) 2007 Gabor Juhos <juhosg at openwrt.org>
+ *  Copyright (C) 2007,2008 Gabor Juhos <juhosg at openwrt.org>
  *
  *  This code was based on a driver for Linux 2.6.xx by Jeroen Vreeken.
  *    Copyright Jeroen Vreeken (pe1rxq@amsat.org), 2005
@@ -43,7 +43,7 @@
 
 #define DRV_NAME	"adm5120-switch"
 #define DRV_DESC	"ADM5120 built-in ethernet switch driver"
-#define DRV_VERSION	"0.1.0"
+#define DRV_VERSION	"0.1.1"
 
 #define CONFIG_ADM5120_SWITCH_NAPI	1
 #undef CONFIG_ADM5120_SWITCH_DEBUG
@@ -93,8 +93,14 @@
 /* ------------------------------------------------------------------------ */
 
 struct adm5120_if_priv {
+	struct net_device *dev;
+
 	unsigned int	vlan_no;
 	unsigned int	port_mask;
+
+#ifdef CONFIG_ADM5120_SWITCH_NAPI
+	struct napi_struct napi;
+#endif
 };
 
 struct dma_desc {
@@ -280,60 +286,59 @@ static void sw_dump_regs(void)
 {
 	u32 t;
 
-	t = SW_READ_REG(PHY_STATUS);
+	t = sw_read_reg(SWITCH_REG_PHY_STATUS);
 	SW_DBG("phy_status: %08X\n", t);
 
-	t = SW_READ_REG(CPUP_CONF);
+	t = sw_read_reg(SWITCH_REG_CPUP_CONF);
 	SW_DBG("cpup_conf: %08X%s%s%s\n", t,
 		(t & CPUP_CONF_DCPUP) ? " DCPUP" : "",
 		(t & CPUP_CONF_CRCP) ? " CRCP" : "",
 		(t & CPUP_CONF_BTM) ? " BTM" : "");
 
-	t = SW_READ_REG(PORT_CONF0);
+	t = sw_read_reg(SWITCH_REG_PORT_CONF0);
 	SW_DBG("port_conf0: %08X\n", t);
-	t = SW_READ_REG(PORT_CONF1);
+	t = sw_read_reg(SWITCH_REG_PORT_CONF1);
 	SW_DBG("port_conf1: %08X\n", t);
-	t = SW_READ_REG(PORT_CONF2);
+	t = sw_read_reg(SWITCH_REG_PORT_CONF2);
 	SW_DBG("port_conf2: %08X\n", t);
 
-	t = SW_READ_REG(VLAN_G1);
+	t = sw_read_reg(SWITCH_REG_VLAN_G1);
 	SW_DBG("vlan g1: %08X\n", t);
-	t = SW_READ_REG(VLAN_G2);
+	t = sw_read_reg(SWITCH_REG_VLAN_G2);
 	SW_DBG("vlan g2: %08X\n", t);
 
-	t = SW_READ_REG(BW_CNTL0);
+	t = sw_read_reg(SWITCH_REG_BW_CNTL0);
 	SW_DBG("bw_cntl0: %08X\n", t);
-	t = SW_READ_REG(BW_CNTL1);
+	t = sw_read_reg(SWITCH_REG_BW_CNTL1);
 	SW_DBG("bw_cntl1: %08X\n", t);
 
-	t = SW_READ_REG(PHY_CNTL0);
+	t = sw_read_reg(SWITCH_REG_PHY_CNTL0);
 	SW_DBG("phy_cntl0: %08X\n", t);
-	t = SW_READ_REG(PHY_CNTL1);
+	t = sw_read_reg(SWITCH_REG_PHY_CNTL1);
 	SW_DBG("phy_cntl1: %08X\n", t);
-	t = SW_READ_REG(PHY_CNTL2);
+	t = sw_read_reg(SWITCH_REG_PHY_CNTL2);
 	SW_DBG("phy_cntl2: %08X\n", t);
-	t = SW_READ_REG(PHY_CNTL3);
+	t = sw_read_reg(SWITCH_REG_PHY_CNTL3);
 	SW_DBG("phy_cntl3: %08X\n", t);
-	t = SW_READ_REG(PHY_CNTL4);
+	t = sw_read_reg(SWITCH_REG_PHY_CNTL4);
 	SW_DBG("phy_cntl4: %08X\n", t);
 
-	t = SW_READ_REG(INT_STATUS);
+	t = sw_read_reg(SWITCH_REG_INT_STATUS);
 	sw_dump_intr_mask("int_status: ", t);
 
-	t = SW_READ_REG(INT_MASK);
+	t = sw_read_reg(SWITCH_REG_INT_MASK);
 	sw_dump_intr_mask("int_mask: ", t);
 
-	t = SW_READ_REG(SHDA);
+	t = sw_read_reg(SWITCH_REG_SHDA);
 	SW_DBG("shda: %08X\n", t);
-	t = SW_READ_REG(SLDA);
+	t = sw_read_reg(SWITCH_REG_SLDA);
 	SW_DBG("slda: %08X\n", t);
-	t = SW_READ_REG(RHDA);
+	t = sw_read_reg(SWITCH_REG_RHDA);
 	SW_DBG("rhda: %08X\n", t);
-	t = SW_READ_REG(RLDA);
+	t = sw_read_reg(SWITCH_REG_RLDA);
 	SW_DBG("rlda: %08X\n", t);
 }
 
-
 /* ------------------------------------------------------------------------ */
 
 static inline void adm5120_rx_dma_update(struct dma_desc *desc,
@@ -430,7 +435,7 @@ static int adm5120_switch_rx(int limit)
 				dma_cache_wback_inv((unsigned long)skb->data,
 					skb->len);
 
-#ifdef CONFIG_ADM5120_SWITCH_USE_NAPI
+#ifdef CONFIG_ADM5120_SWITCH_NAPI
 				netif_receive_skb(skb);
 #else
 				netif_rx(skb);
@@ -495,9 +500,11 @@ static void adm5120_switch_tx(void)
 }
 
 #ifdef CONFIG_ADM5120_SWITCH_NAPI
-static int adm5120_if_poll(struct net_device *dev, int *budget)
+static int adm5120_if_poll(struct napi_struct *napi, int limit)
 {
-	int limit = min(dev->quota, *budget);
+	struct adm5120_if_priv *priv = container_of(napi,
+				struct adm5120_if_priv, napi);
+	struct net_device *dev = priv->dev;
 	int done;
 	u32 status;
 
@@ -509,13 +516,10 @@ static int adm5120_if_poll(struct net_device *dev, int *budget)
 	SW_DBG("%s: processing RX ring\n", dev->name);
 	done = adm5120_switch_rx(limit);
 
-	*budget -= done;
-	dev->quota -= done;
-
 	status = sw_int_status() & SWITCH_INTS_POLL;
 	if ((done < limit) && (!status)) {
 		SW_DBG("disable polling mode for %s\n", dev->name);
-		netif_rx_complete(dev);
+		netif_rx_complete(dev, napi);
 		sw_int_unmask(SWITCH_INTS_POLL);
 		return 0;
 	}
@@ -524,7 +528,7 @@ static int adm5120_if_poll(struct net_device *dev, int *budget)
 			dev->name, done, status);
 	return 1;
 }
-#endif /* CONFIG_ADM5120_SWITCH_USE_NAPI */
+#endif /* CONFIG_ADM5120_SWITCH_NAPI */
 
 
 static irqreturn_t adm5120_switch_irq(int irq, void *dev_id)
@@ -541,10 +545,12 @@ static irqreturn_t adm5120_switch_irq(int irq, void *dev_id)
 
 	if (status & SWITCH_INTS_POLL) {
 		struct net_device *dev = dev_id;
+		struct adm5120_if_priv *priv = netdev_priv(dev);
+
 		sw_dump_intr_mask("poll ints", status);
 		SW_DBG("enable polling mode for %s\n", dev->name);
 		sw_int_mask(SWITCH_INTS_POLL);
-		netif_rx_schedule(dev);
+		netif_rx_schedule(dev, &priv->napi);
 	}
 #else
 	sw_int_ack(status);
@@ -709,7 +715,7 @@ static void adm5120_write_mac(struct net_device *dev)
 	u32 t;
 
 	t = mac[2] | (mac[3] << MAC_WT1_MAC3_SHIFT) |
-		(mac[4] << MAC_WT1_MAC4_SHIFT) | (mac[5] << MAC_WT1_MAC4_SHIFT);
+		(mac[4] << MAC_WT1_MAC4_SHIFT) | (mac[5] << MAC_WT1_MAC5_SHIFT);
 	sw_write_reg(SWITCH_REG_MAC_WT1, t);
 
 	t = (mac[0] << MAC_WT0_MAC0_SHIFT) | (mac[1] << MAC_WT0_MAC1_SHIFT) |
@@ -746,7 +752,7 @@ static void adm5120_switch_set_vlan_mac(unsigned int vlan, unsigned char *mac)
 
 	t = mac[2] | (mac[3] << MAC_WT1_MAC3_SHIFT)
 		| (mac[4] << MAC_WT1_MAC4_SHIFT)
-		| (mac[5] << MAC_WT1_MAC4_SHIFT);
+		| (mac[5] << MAC_WT1_MAC5_SHIFT);
 	sw_write_reg(SWITCH_REG_MAC_WT1, t);
 
 	t = (mac[0] << MAC_WT0_MAC0_SHIFT) | (mac[1] << MAC_WT0_MAC1_SHIFT) |
@@ -779,12 +785,31 @@ static void adm5120_switch_set_vlan_ports(unsigned int vlan, u32 ports)
 
 /* ------------------------------------------------------------------------ */
 
+#ifdef CONFIG_ADM5120_SWITCH_NAPI
+static inline void adm5120_if_napi_enable(struct net_device *dev)
+{
+	struct adm5120_if_priv *priv = netdev_priv(dev);
+	napi_enable(&priv->napi);
+}
+
+static inline void adm5120_if_napi_disable(struct net_device *dev)
+{
+	struct adm5120_if_priv *priv = netdev_priv(dev);
+	napi_disable(&priv->napi);
+}
+#else
+static inline void adm5120_if_napi_enable(struct net_device *dev) {}
+static inline void adm5120_if_napi_disable(struct net_device *dev) {}
+#endif /* CONFIG_ADM5120_SWITCH_NAPI */
+
 static int adm5120_if_open(struct net_device *dev)
 {
 	u32 t;
 	int err;
 	int i;
 
+	adm5120_if_napi_enable(dev);
+
 	err = request_irq(dev->irq, adm5120_switch_irq,
 		(IRQF_SHARED | IRQF_DISABLED), dev->name, dev);
 	if (err) {
@@ -809,6 +834,7 @@ static int adm5120_if_open(struct net_device *dev)
 	return 0;
 
 err:
+	adm5120_if_napi_disable(dev);
 	return err;
 }
 
@@ -818,6 +844,7 @@ static int adm5120_if_stop(struct net_device *dev)
 	int i;
 
 	netif_stop_queue(dev);
+	adm5120_if_napi_disable(dev);
 
 	/* disable port if not assigned to other devices */
 	t = sw_read_reg(SWITCH_REG_PORT_CONF0);
@@ -843,6 +870,7 @@ static int adm5120_if_hard_start_xmit(struct sk_buff *skb,
 	struct adm5120_if_priv *priv = netdev_priv(dev);
 	unsigned int entry;
 	unsigned long data;
+	int i;
 
 	/* lock switch irq */
 	spin_lock_irq(&tx_lock);
@@ -875,8 +903,11 @@ static int adm5120_if_hard_start_xmit(struct sk_buff *skb,
 
 	cur_txl++;
 	if (cur_txl == dirty_txl + TX_QUEUE_LEN) {
-		/* FIXME: stop queue for all devices */
-		netif_stop_queue(dev);
+		for (i = 0; i < SWITCH_NUM_PORTS; i++) {
+			if (!adm5120_devs[i])
+				continue;
+			netif_stop_queue(adm5120_devs[i]);
+		}
 	}
 
 	dev->trans_start = jiffies;
@@ -997,6 +1028,9 @@ static struct net_device *adm5120_if_alloc(void)
 	if (!dev)
 		return NULL;
 
+	priv = netdev_priv(dev);
+	priv->dev = dev;
+
 	dev->irq		= ADM5120_IRQ_SWITCH;
 	dev->open		= adm5120_if_open;
 	dev->hard_start_xmit 	= adm5120_if_hard_start_xmit;
@@ -1006,13 +1040,11 @@ static struct net_device *adm5120_if_alloc(void)
 	dev->tx_timeout		= adm5120_if_tx_timeout;
 	dev->watchdog_timeo 	= TX_TIMEOUT;
 	dev->set_mac_address 	= adm5120_if_set_mac_address;
+
 #ifdef CONFIG_ADM5120_SWITCH_NAPI
-	dev->poll		= adm5120_if_poll;
-	dev->weight		= 64;
+	netif_napi_add(dev, &priv->napi, adm5120_if_poll, 64);
 #endif
 
-	SET_MODULE_OWNER(dev);
-
 	return dev;
 }
 
@@ -1061,7 +1093,7 @@ static int __init adm5120_switch_probe(struct platform_device *pdev)
 		(SWITCH_PORTS_PHY << PHY_CNTL2_PHYR_SHIFT) |
 		(SWITCH_PORTS_PHY << PHY_CNTL2_AMDIX_SHIFT) |
 		PHY_CNTL2_RMAE;
-	SW_WRITE_REG(PHY_CNTL2, t);
+	sw_write_reg(SWITCH_REG_PHY_CNTL2, t);
 
 	t = sw_read_reg(SWITCH_REG_PHY_CNTL3);
 	t |= PHY_CNTL3_RNT;