generic: rtl8366: add common rtl8366_sw_get_port_mib function

[openwrt.git] / target / linux / generic / files / drivers / net / phy / rtl8366rb.c

diff --git a/target/linux/generic/files/drivers/net/phy/rtl8366rb.c b/target/linux/generic/files/drivers/net/phy/rtl8366rb.c
index f23ec21..b6d3f98 100644 (file)
--- a/target/linux/generic/files/drivers/net/phy/rtl8366rb.c
+++ b/target/linux/generic/files/drivers/net/phy/rtl8366rb.c
@@ -15,7 +15,6 @@
 #include <linux/platform_device.h>
 #include <linux/delay.h>
 #include <linux/skbuff.h>
 #include <linux/platform_device.h>
 #include <linux/delay.h>
 #include <linux/skbuff.h>

-#include <linux/switch.h>

 #include <linux/rtl8366rb.h>
 
 #include "rtl8366_smi.h"
 #include <linux/rtl8366rb.h>
 
 #include "rtl8366_smi.h"


@@ -164,12 +163,6 @@
 #define RTL8366RB_VLAN_MEMBER_MASK     0xff
 #define RTL8366RB_VLAN_FID_MASK                0x7
 
 #define RTL8366RB_VLAN_MEMBER_MASK     0xff
 #define RTL8366RB_VLAN_FID_MASK                0x7
 

-struct rtl8366rb {
-       struct device           *parent;
-       struct rtl8366_smi      smi;
-       struct switch_dev       dev;
-};
-

 static struct rtl8366_mib_counter rtl8366rb_mib_counters[] = {
        { 0,  0, 4, "IfInOctets"                                },
        { 0,  4, 4, "EtherStatsOctets"                          },
 static struct rtl8366_mib_counter rtl8366rb_mib_counters[] = {
        { 0,  0, 4, "IfInOctets"                                },
        { 0,  4, 4, "EtherStatsOctets"                          },


@@ -220,22 +213,6 @@ static struct rtl8366_mib_counter rtl8366rb_mib_counters[] = {
                        return err;                                     \
        } while (0)
 
                        return err;                                     \
        } while (0)
 

-static inline struct rtl8366rb *smi_to_rtl8366rb(struct rtl8366_smi *smi)
-{
-       return container_of(smi, struct rtl8366rb, smi);
-}
-
-static inline struct rtl8366rb *sw_to_rtl8366rb(struct switch_dev *sw)
-{
-       return container_of(sw, struct rtl8366rb, dev);
-}
-
-static inline struct rtl8366_smi *sw_to_rtl8366_smi(struct switch_dev *sw)
-{
-       struct rtl8366rb *rtl = sw_to_rtl8366rb(sw);
-       return &rtl->smi;
-}
-

 static int rtl8366rb_reset_chip(struct rtl8366_smi *smi)
 {
        int timeout = 10;
 static int rtl8366rb_reset_chip(struct rtl8366_smi *smi)
 {
        int timeout = 10;


@@ -815,38 +792,6 @@ static int rtl8366rb_sw_reset_port_mibs(struct switch_dev *dev,
                                RTL8366RB_MIB_CTRL_PORT_RESET(val->port_vlan));
 }
 
                                RTL8366RB_MIB_CTRL_PORT_RESET(val->port_vlan));
 }
 

-static int rtl8366rb_sw_get_port_mib(struct switch_dev *dev,
-                                   const struct switch_attr *attr,
-                                   struct switch_val *val)
-{
-       struct rtl8366_smi *smi = sw_to_rtl8366_smi(dev);
-       int i, len = 0;
-       unsigned long long counter = 0;
-       char *buf = smi->buf;
-
-       if (val->port_vlan >= RTL8366RB_NUM_PORTS)
-               return -EINVAL;
-
-       len += snprintf(buf + len, sizeof(smi->buf) - len,
-                       "Port %d MIB counters\n",
-                       val->port_vlan);
-
-       for (i = 0; i < ARRAY_SIZE(rtl8366rb_mib_counters); ++i) {
-               len += snprintf(buf + len, sizeof(smi->buf) - len,
-                               "%-36s: ", rtl8366rb_mib_counters[i].name);
-               if (!rtl8366rb_get_mib_counter(smi, i, val->port_vlan, &counter))
-                       len += snprintf(buf + len, sizeof(smi->buf) - len,
-                                       "%llu\n", counter);
-               else
-                       len += snprintf(buf + len, sizeof(smi->buf) - len,
-                                       "%s\n", "error");
-       }
-
-       val->value.s = buf;
-       val->len = len;
-       return 0;
-}
-

 static int rtl8366rb_sw_get_vlan_ports(struct switch_dev *dev,
                                      struct switch_val *val)
 {
 static int rtl8366rb_sw_get_vlan_ports(struct switch_dev *dev,
                                      struct switch_val *val)
 {


@@ -898,18 +843,6 @@ static int rtl8366rb_sw_set_vlan_ports(struct switch_dev *dev,
        return rtl8366_set_vlan(smi, val->port_vlan, member, untag, 0);
 }
 
        return rtl8366_set_vlan(smi, val->port_vlan, member, untag, 0);
 }
 

-static int rtl8366rb_sw_get_port_pvid(struct switch_dev *dev, int port, int *val)
-{
-       struct rtl8366_smi *smi = sw_to_rtl8366_smi(dev);
-       return rtl8366_get_pvid(smi, port, val);
-}
-
-static int rtl8366rb_sw_set_port_pvid(struct switch_dev *dev, int port, int val)
-{
-       struct rtl8366_smi *smi = sw_to_rtl8366_smi(dev);
-       return rtl8366_set_pvid(smi, port, val);
-}
-

 static int rtl8366rb_sw_reset_switch(struct switch_dev *dev)
 {
        struct rtl8366_smi *smi = sw_to_rtl8366_smi(dev);
 static int rtl8366rb_sw_reset_switch(struct switch_dev *dev)
 {
        struct rtl8366_smi *smi = sw_to_rtl8366_smi(dev);


@@ -978,7 +911,7 @@ static struct switch_attr rtl8366rb_port[] = {
                .description = "Get MIB counters for port",
                .max = 33,
                .set = NULL,
                .description = "Get MIB counters for port",
                .max = 33,
                .set = NULL,

-               .get = rtl8366rb_sw_get_port_mib,
+               .get = rtl8366_sw_get_port_mib,

        }, {
                .type = SWITCH_TYPE_INT,
                .name = "led",
        }, {
                .type = SWITCH_TYPE_INT,
                .name = "led",


@@ -1021,30 +954,30 @@ static struct switch_dev rtl8366_switch_dev = {
 
        .get_vlan_ports = rtl8366rb_sw_get_vlan_ports,
        .set_vlan_ports = rtl8366rb_sw_set_vlan_ports,
 
        .get_vlan_ports = rtl8366rb_sw_get_vlan_ports,
        .set_vlan_ports = rtl8366rb_sw_set_vlan_ports,

-       .get_port_pvid = rtl8366rb_sw_get_port_pvid,
-       .set_port_pvid = rtl8366rb_sw_set_port_pvid,
+       .get_port_pvid = rtl8366_sw_get_port_pvid,
+       .set_port_pvid = rtl8366_sw_set_port_pvid,

        .reset_switch = rtl8366rb_sw_reset_switch,
 };
 
        .reset_switch = rtl8366rb_sw_reset_switch,
 };
 

-static int rtl8366rb_switch_init(struct rtl8366rb *rtl)
+static int rtl8366rb_switch_init(struct rtl8366_smi *smi)

 {
 {

-       struct switch_dev *dev = &rtl->dev;
+       struct switch_dev *dev = &smi->sw_dev;

        int err;
 
        memcpy(dev, &rtl8366_switch_dev, sizeof(struct switch_dev));
        int err;
 
        memcpy(dev, &rtl8366_switch_dev, sizeof(struct switch_dev));

-       dev->priv = rtl;
-       dev->devname = dev_name(rtl->parent);
+       dev->priv = smi;
+       dev->devname = dev_name(smi->parent);

 
        err = register_switch(dev, NULL);
        if (err)
 
        err = register_switch(dev, NULL);
        if (err)

-               dev_err(rtl->parent, "switch registration failed\n");
+               dev_err(smi->parent, "switch registration failed\n");

 
        return err;
 }
 
 
        return err;
 }
 

-static void rtl8366rb_switch_cleanup(struct rtl8366rb *rtl)
+static void rtl8366rb_switch_cleanup(struct rtl8366_smi *smi)

 {
 {

-       unregister_switch(&rtl->dev);
+       unregister_switch(&smi->sw_dev);

 }
 
 static int rtl8366rb_mii_read(struct mii_bus *bus, int addr, int reg)
 }
 
 static int rtl8366rb_mii_read(struct mii_bus *bus, int addr, int reg)


@@ -1079,9 +1012,8 @@ static int rtl8366rb_mii_bus_match(struct mii_bus *bus)
                bus->write == rtl8366rb_mii_write);
 }
 
                bus->write == rtl8366rb_mii_write);
 }
 

-static int rtl8366rb_setup(struct rtl8366rb *rtl)
+static int rtl8366rb_setup(struct rtl8366_smi *smi)

 {
 {

-       struct rtl8366_smi *smi = &rtl->smi;

        int ret;
 
        ret = rtl8366rb_reset_chip(smi);
        int ret;
 
        ret = rtl8366rb_reset_chip(smi);


@@ -1127,6 +1059,8 @@ static int rtl8366rb_detect(struct rtl8366_smi *smi)
 
 static struct rtl8366_smi_ops rtl8366rb_smi_ops = {
        .detect         = rtl8366rb_detect,
 
 static struct rtl8366_smi_ops rtl8366rb_smi_ops = {
        .detect         = rtl8366rb_detect,

+       .setup          = rtl8366rb_setup,
+

        .mii_read       = rtl8366rb_mii_read,
        .mii_write      = rtl8366rb_mii_write,
 
        .mii_read       = rtl8366rb_mii_read,
        .mii_write      = rtl8366rb_mii_write,
 


@@ -1143,7 +1077,6 @@ static int __init rtl8366rb_probe(struct platform_device *pdev)
 {
        static int rtl8366_smi_version_printed;
        struct rtl8366rb_platform_data *pdata;
 {
        static int rtl8366_smi_version_printed;
        struct rtl8366rb_platform_data *pdata;

-       struct rtl8366rb *rtl;

        struct rtl8366_smi *smi;
        int err;
 
        struct rtl8366_smi *smi;
        int err;
 


@@ -1158,17 +1091,12 @@ static int __init rtl8366rb_probe(struct platform_device *pdev)
                goto err_out;
        }
 
                goto err_out;
        }
 

-       rtl = kzalloc(sizeof(*rtl), GFP_KERNEL);
-       if (!rtl) {
-               dev_err(&pdev->dev, "no memory for private data\n");
+       smi = rtl8366_smi_alloc(&pdev->dev);
+       if (!smi) {

                err = -ENOMEM;
                goto err_out;
        }
 
                err = -ENOMEM;
                goto err_out;
        }
 

-       rtl->parent = &pdev->dev;
-
-       smi = &rtl->smi;
-       smi->parent = &pdev->dev;

        smi->gpio_sda = pdata->gpio_sda;
        smi->gpio_sck = pdata->gpio_sck;
        smi->ops = &rtl8366rb_smi_ops;
        smi->gpio_sda = pdata->gpio_sda;
        smi->gpio_sck = pdata->gpio_sck;
        smi->ops = &rtl8366rb_smi_ops;


@@ -1180,15 +1108,11 @@ static int __init rtl8366rb_probe(struct platform_device *pdev)
 
        err = rtl8366_smi_init(smi);
        if (err)
 
        err = rtl8366_smi_init(smi);
        if (err)

-               goto err_free_rtl;
-
-       platform_set_drvdata(pdev, rtl);
+               goto err_free_smi;

 
 

-       err = rtl8366rb_setup(rtl);
-       if (err)
-               goto err_clear_drvdata;
+       platform_set_drvdata(pdev, smi);

 
 

-       err = rtl8366rb_switch_init(rtl);
+       err = rtl8366rb_switch_init(smi);

        if (err)
                goto err_clear_drvdata;
 
        if (err)
                goto err_clear_drvdata;
 


@@ -1197,8 +1121,8 @@ static int __init rtl8366rb_probe(struct platform_device *pdev)
  err_clear_drvdata:
        platform_set_drvdata(pdev, NULL);
        rtl8366_smi_cleanup(smi);
  err_clear_drvdata:
        platform_set_drvdata(pdev, NULL);
        rtl8366_smi_cleanup(smi);

- err_free_rtl:
-       kfree(rtl);
+ err_free_smi:
+       kfree(smi);

  err_out:
        return err;
 }
  err_out:
        return err;
 }


@@ -1231,13 +1155,13 @@ static struct phy_driver rtl8366rb_phy_driver = {
 
 static int __devexit rtl8366rb_remove(struct platform_device *pdev)
 {
 
 static int __devexit rtl8366rb_remove(struct platform_device *pdev)
 {

-       struct rtl8366rb *rtl = platform_get_drvdata(pdev);
+       struct rtl8366_smi *smi = platform_get_drvdata(pdev);

 
 

-       if (rtl) {
-               rtl8366rb_switch_cleanup(rtl);
+       if (smi) {
+               rtl8366rb_switch_cleanup(smi);

                platform_set_drvdata(pdev, NULL);
                platform_set_drvdata(pdev, NULL);

-               rtl8366_smi_cleanup(&rtl->smi);
-               kfree(rtl);
+               rtl8366_smi_cleanup(smi);
+               kfree(smi);

        }
 
        return 0;
        }
 
        return 0;