fix CRC32 calculation for sysupgrade

[openwrt.git] / tools / firmware-utils / src / trx.c

diff --git a/tools/firmware-utils/src/trx.c b/tools/firmware-utils/src/trx.c
index fbae789..9697ad7 100644 (file)
--- a/tools/firmware-utils/src/trx.c
+++ b/tools/firmware-utils/src/trx.c
@@ -98,10 +98,11 @@ int main(int argc, char **argv)
        int c, i, append = 0;
        size_t n;
        ssize_t n2;
-       uint32_t cur_len;
+       uint32_t cur_len, fsmark=0;
        unsigned long maxlen = TRX_MAX_LEN;
        struct trx_header *p;
        char trx_version = 1;
+       unsigned char binheader[32];
 
        fprintf(stderr, "mjn3's trx replacement - v0.81.1\n");
 
@@ -130,6 +131,8 @@ int main(int argc, char **argv)
                                        cur_len += 4;
                                }
                                break;
+                       case 'F':
+                               fsmark = cur_len;
                        case 'A':
                                append = 1;
                                /* fall through */
@@ -213,7 +216,7 @@ int main(int argc, char **argv)
                                        usage();
                                }
                                if (n < cur_len) {
-                                       fprintf(stderr, "WARNING: current length exceeds -b %d offset\n",n);
+                                       fprintf(stderr, "WARNING: current length exceeds -b %d offset\n",(int) n);
                                } else {
                                        memset(buf + cur_len, 0, n - cur_len);
                                        cur_len = n;
@@ -228,7 +231,7 @@ int main(int argc, char **argv)
                                }
                                if (n2 < 0) {
                                        if (-n2 > cur_len) {
-                                               fprintf(stderr, "WARNING: current length smaller then -x %d offset\n",n2);
+                                               fprintf(stderr, "WARNING: current length smaller then -x %d offset\n",(int) n2);
                                                cur_len = 0;
                                        } else
                                                cur_len += n2;
@@ -257,11 +260,26 @@ int main(int argc, char **argv)
                cur_len += ROUND - n;
        }
 
+       /* for TRXv2 set bin-header Flags to 0xFF for CRC calculation like CFE does */ 
+       if (trx_version == 2) {
+               if(cur_len - p->offsets[3] < sizeof(binheader)) {
+                       fprintf(stderr, "TRXv2 binheader too small!\n");
+                       return EXIT_FAILURE;
+               }
+               memcpy(binheader, buf + p->offsets[3], sizeof(binheader)); /* save header */
+               memset(buf + p->offsets[3] + 22, 0xFF, 8); /* set stable and try1-3 to 0xFF */
+       }
+
        p->crc32 = crc32buf((char *) &p->flag_version,
-                                               cur_len - offsetof(struct trx_header, flag_version));
+                                               (fsmark)?fsmark:cur_len - offsetof(struct trx_header, flag_version));
        p->crc32 = STORE32_LE(p->crc32);
 
-       p->len = STORE32_LE(cur_len);
+       p->len = (fsmark)?fsmark:cur_len - offsetof(struct trx_header, flag_version);
+
+       /* restore TRXv2 bin-header */
+       if (trx_version == 2) {
+               memcpy(buf + p->offsets[3], binheader, sizeof(binheader));
+       }
 
        if (!fwrite(buf, cur_len, 1, out) || fflush(out)) {
                fprintf(stderr, "fwrite failed\n");