X-Git-Url: https://git.rohieb.name/openwrt.git/blobdiff_plain/15b63637b4acc1f474148c160cda9f07be351dd0..ddc9278d09957a5c6cb27ad0ca696f096476e38a:/package/firewall/files/lib/core.sh?ds=sidebyside

diff --git a/package/firewall/files/lib/core.sh b/package/firewall/files/lib/core.sh
index f37b1e696..c38359781 100644
--- a/package/firewall/files/lib/core.sh
+++ b/package/firewall/files/lib/core.sh
@@ -8,14 +8,13 @@ include /lib/network
 fw_start() {
 	fw_init
 
-	lock /var/lock/firewall.start
-
 	FW_DEFAULTS_APPLIED=
 
 	fw_is_loaded && {
 		echo "firewall already loaded" >&2
 		exit 1
 	}
+
 	uci_set_state firewall core "" firewall_state
 
 	fw_clear DROP
@@ -40,7 +39,7 @@ fw_start() {
 	echo "Loading includes"
 	config_foreach fw_load_include include
 
-	[ -n "$FW_NOTRACK_DISABLED" ] && {
+	[ -z "$FW_NOTRACK_DISABLED" ] && {
 		echo "Optimizing conntrack"
 		config_foreach fw_load_notrack_zone zone
 	}
@@ -50,9 +49,8 @@ fw_start() {
 
 	fw_callback post core
 
+	uci_set_state firewall core zones "$FW_ZONES"
 	uci_set_state firewall core loaded 1
-
-	lock -u /var/lock/firewall.start
 }
 
 fw_stop() {
@@ -60,6 +58,17 @@ fw_stop() {
 
 	fw_callback pre stop
 
+	local z n i
+	config_get z core zones
+	for z in $z; do
+		config_get n core "${z}_networks"
+		for n in $n; do
+			config_get i core "${n}_ifname"
+			[ -n "$i" ] && env -i ACTION=remove ZONE="$z" \
+				INTERFACE="$n" DEVICE="$i" /sbin/hotplug-call firewall
+		done
+	done
+
 	fw_clear ACCEPT
 
 	fw_callback post stop
@@ -84,7 +93,7 @@ fw_reload() {
 }
 
 fw_is_loaded() {
-	local bool=$(uci -q -P /var/state get firewall.core.loaded)
+	local bool=$(uci_get_state firewall.core.loaded)
 	return $((! ${bool:-0}))
 }
 
@@ -98,10 +107,8 @@ fw_die() {
 
 fw_log() {
 	local level="$1"
-	[ -n "$2" ] || {
-		shift
-		level=notice
-	}
+	[ -n "$2" ] && shift || level=notice
+	[ "$level" != error ] || echo "Error: $@" >&2
 	logger -t firewall -p user.$level "$@"
 }