X-Git-Url: https://git.rohieb.name/openwrt.git/blobdiff_plain/25c15c7d1f72fc6c0e6027f161b137a4b2da79b8..526e421dbd2c9b9ff22234b841a7e8df2d9d45ea:/target/linux/ramips/files/arch/mips/pci/pci-rt288x.c

diff --git a/target/linux/ramips/files/arch/mips/pci/pci-rt288x.c b/target/linux/ramips/files/arch/mips/pci/pci-rt288x.c
index e3b05d061..76b70d09e 100644
--- a/target/linux/ramips/files/arch/mips/pci/pci-rt288x.c
+++ b/target/linux/ramips/files/arch/mips/pci/pci-rt288x.c
@@ -36,8 +36,8 @@ static void rt2880_pci_reg_write(u32 val, u32 reg)
 	writel(val, rt2880_pci_base + reg);
 }
 
-static int config_access(unsigned char access_type, struct pci_bus *bus,
-			 unsigned int devfn, unsigned char where, u32 *data)
+static void config_access(unsigned char access_type, struct pci_bus *bus,
+			  unsigned int devfn, unsigned char where, u32 *data)
 {
 	unsigned int slot = PCI_SLOT(devfn);
 	unsigned int address;
@@ -51,8 +51,6 @@ static int config_access(unsigned char access_type, struct pci_bus *bus,
 		rt2880_pci_reg_write(*data, RT2880_PCI_REG_CONFIG_DATA);
 	else
 		*data = rt2880_pci_reg_read(RT2880_PCI_REG_CONFIG_DATA);
-
-	return 0;
 }
 
 static int rt2880_pci_config_read(struct pci_bus *bus, unsigned int devfn,
@@ -60,8 +58,7 @@ static int rt2880_pci_config_read(struct pci_bus *bus, unsigned int devfn,
 {
 	u32 data = 0;
 
-	if (config_access(PCI_ACCESS_READ, bus, devfn, where, &data))
-		return PCIBIOS_DEVICE_NOT_FOUND;
+	config_access(PCI_ACCESS_READ, bus, devfn, where, &data);
 
 	if (size == 1)
 		*val = (data >> ((where & 3) << 3)) & 0xff;
@@ -81,8 +78,7 @@ static int rt2880_pci_config_write(struct pci_bus *bus, unsigned int devfn,
 	if (size == 4) {
 		data = val;
 	} else {
-		if (config_access(PCI_ACCESS_READ, bus, devfn, where, &data))
-			return PCIBIOS_DEVICE_NOT_FOUND;
+		config_access(PCI_ACCESS_READ, bus, devfn, where, &data);
 		if (size == 1)
 			data = (data & ~(0xff << ((where & 3) << 3))) |
 			       (val << ((where & 3) << 3));
@@ -91,8 +87,7 @@ static int rt2880_pci_config_write(struct pci_bus *bus, unsigned int devfn,
 			       (val << ((where & 3) << 3));
 	}
 
-	if (config_access(PCI_ACCESS_WRITE, bus, devfn, where, &data))
-		return PCIBIOS_DEVICE_NOT_FOUND;
+	config_access(PCI_ACCESS_WRITE, bus, devfn, where, &data);
 
 	return PCIBIOS_SUCCESSFUL;
 }
@@ -122,9 +117,9 @@ static struct pci_controller rt2880_pci_controller = {
 	.io_resource	= &rt2880_pci_mem_resource,
 };
 
-void inline read_config(unsigned long bus, unsigned long dev,
-			unsigned long func, unsigned long reg,
-			unsigned long *val)
+static inline void read_config(unsigned long bus, unsigned long dev,
+			       unsigned long func, unsigned long reg,
+			       unsigned long *val)
 {
 	unsigned long address;
 
@@ -134,9 +129,9 @@ void inline read_config(unsigned long bus, unsigned long dev,
 	*val = rt2880_pci_reg_read(RT2880_PCI_REG_CONFIG_DATA);
 }
 
-void inline write_config(unsigned long bus, unsigned long dev,
-			 unsigned long func, unsigned long reg,
-			 unsigned long val)
+static inline void write_config(unsigned long bus, unsigned long dev,
+				unsigned long func, unsigned long reg,
+				unsigned long val)
 {
 	unsigned long address;