X-Git-Url: https://git.rohieb.name/openwrt.git/blobdiff_plain/3b07b2b809e18cd405a7c0576f505bcc4b0455ee..f8c4b35cc4bb2e3ddba5aef51fc3327fe6bc3435:/package/firewall/files/lib/core_interface.sh

diff --git a/package/firewall/files/lib/core_interface.sh b/package/firewall/files/lib/core_interface.sh
index e6630a5ca..8023e7fb8 100644
--- a/package/firewall/files/lib/core_interface.sh
+++ b/package/firewall/files/lib/core_interface.sh
@@ -1,4 +1,35 @@
-# Copyright (C) 2009-2010 OpenWrt.org
+# Copyright (C) 2009-2011 OpenWrt.org
+
+fw__uci_state_add() {
+	local var="$1"
+	local item="$2"
+
+	local val="$(uci_get_state firewall core $var)"
+	local e1; for e1 in $item; do
+		local e2; for e2 in $val; do
+			[ "$e1" = "$e2" ] && e1=""
+		done
+		val="${val:+$val${e1:+ }}$e1"
+	done
+
+	uci_toggle_state firewall core $var "$val"
+}
+
+fw__uci_state_del() {
+	local var="$1"
+	local item="$2"
+
+	local rest=""
+	local val="$(uci_get_state firewall core $var)"
+	local e1; for e1 in $val; do
+		local e2; for e2 in $item; do
+			[ "$e1" = "$e2" ] && e1=""
+		done
+		rest="${rest:+$rest${e1:+ }}$e1"
+	done
+
+	uci_toggle_state firewall core $var "$val"
+}
 
 fw_configure_interface() {
 	local iface=$1
@@ -12,8 +43,9 @@ fw_configure_interface() {
 	}
 
 	[ -n "$ifname" ] || {
-		ifname=$(uci_get_state network "$iface" ifname "$iface")
+		ifname=$(uci_get_state network "$iface" ifname)
 		ifname="${ifname%%:*}"
+		[ -z "$ifname" ] && return 0
 	}
 
 	[ "$ifname" == "lo" ] && return 0
@@ -27,21 +59,21 @@ fw_configure_interface() {
 		local ifname=$3
 		local subnet=$4
 
-		local inet onet
-		local mode=$(fw_get_family_mode x $zone i)
+		local inet onet mode
+		fw_get_family_mode mode x $zone i
 
 		case "$mode/$subnet" in
 			# Zone supports v6 only or dual, need v6
-			6/*:*|i/*:*)
-				inet="{ -s $subnet -d ::/0 }"
-				onet="{ -s ::/0 -d $subnet }"
+			G6/*:*|i/*:*)
+				inet="-s $subnet -d ::/0"
+				onet="-s ::/0 -d $subnet"
 				mode=6
 			;;
 
 			# Zone supports v4 only or dual, need v4
-			4/*.*.*.*|i/*.*.*.*)
-				inet="{ -s $subnet -d 0.0.0.0/0 }"
-				onet="{ -s 0.0.0.0/0 -d $subnet }"
+			G4/*.*.*.*|i/*.*.*.*)
+				inet="-s $subnet -d 0.0.0.0/0"
+				onet="-s 0.0.0.0/0 -d $subnet"
 				mode=4
 			;;
 
@@ -50,22 +82,31 @@ fw_configure_interface() {
 
 			# Need v4 while zone is v6
 			*/*.*) fw_log info "zone $zone does not support IPv4 address family, skipping"; return ;;
+
+			# Strip prefix
+			*) mode="${mode#G}" ;;
 		esac
 
-		fw $action $mode f ${chain}_ACCEPT ACCEPT ^ $onet { -o "$ifname" }
-		fw $action $mode f ${chain}_ACCEPT ACCEPT ^ $inet { -i "$ifname" }
-		fw $action $mode f ${chain}_DROP   DROP   ^ $onet { -o "$ifname" }
-		fw $action $mode f ${chain}_DROP   DROP   ^ $inet { -i "$ifname" }
-		fw $action $mode f ${chain}_REJECT reject ^ $onet { -o "$ifname" }
-		fw $action $mode f ${chain}_REJECT reject ^ $inet { -i "$ifname" }
+		lock /var/run/firewall-interface.lock
+
+		fw $action $mode f ${chain}_ACCEPT ACCEPT $ { -o "$ifname" $onet }
+		fw $action $mode f ${chain}_ACCEPT ACCEPT $ { -i "$ifname" $inet }
+		fw $action $mode f ${chain}_DROP   DROP   $ { -o "$ifname" $onet }
+		fw $action $mode f ${chain}_DROP   DROP   $ { -i "$ifname" $inet }
+		fw $action $mode f ${chain}_REJECT reject $ { -o "$ifname" $onet }
+		fw $action $mode f ${chain}_REJECT reject $ { -i "$ifname" $inet }
 
-		fw $action $mode n ${chain}_nat MASQUERADE ^ $onet { -o "$ifname" }
-		fw $action $mode f ${chain}_MSSFIX TCPMSS  ^ $onet { -o "$ifname" -p tcp --tcp-flags SYN,RST SYN --clamp-mss-to-pmtu }
+		[ "$(uci_get_state firewall core "${zone}_tcpmss")" == 1 ] && \
+			fw $action $mode m ${chain}_MSSFIX TCPMSS $ \
+				{ -o "$ifname" -p tcp --tcp-flags SYN,RST SYN --clamp-mss-to-pmtu $onet }
 
-		fw $action $mode f input   ${chain}         $ $inet { -i "$ifname" }
-		fw $action $mode f forward ${chain}_forward $ $inet { -i "$ifname" }
-		fw $action $mode n PREROUTING ${chain}_prerouting ^ $inet { -i "$ifname" }
-		fw $action $mode r PREROUTING ${chain}_notrack    ^ $inet { -i "$ifname" }
+		fw $action $mode f input   ${chain}         $ { -i "$ifname" $inet }
+		fw $action $mode f forward ${chain}_forward $ { -i "$ifname" $inet }
+		fw $action $mode n PREROUTING ${chain}_prerouting $ { -i "$ifname" $inet }
+		fw $action $mode r PREROUTING ${chain}_notrack    $ { -i "$ifname" $inet }
+		fw $action $mode n POSTROUTING ${chain}_nat       $ { -o "$ifname" $onet }
+
+		lock -u /var/run/firewall-interface.lock
 	}
 
 	local old_zones old_ifname old_subnets
@@ -82,7 +123,10 @@ fw_configure_interface() {
 				fw__do_rules del $z $old_ifname $n
 			done
 
-			[ -n "$old_subnets" ] || ACTION=remove ZONE="$z" INTERFACE="$iface" DEVICE="$ifname" /sbin/hotplug-call firewall
+			[ -n "$old_subnets" ] || {
+				fw__uci_state_del "${z}_networks" "$iface"
+				env -i ACTION=remove ZONE="$z" INTERFACE="$iface" DEVICE="$ifname" /sbin/hotplug-call firewall
+			}
 		done
 
 		local old_aliases
@@ -101,19 +145,6 @@ fw_configure_interface() {
 
 	[ "$action" == del ] && return
 
-	local new_zones=
-	load_zone() {
-		fw_config_get_zone "$1"
-		list_contains zone_network "$iface" || return
-
-		fw_log info "adding $iface ($ifname${aliasnet:+ alias $aliasnet}) to zone $zone_name"
-		fw__do_rules add ${zone_name} "$ifname" $aliasnet
-		append new_zones $zone_name
-
-		[ -n "$aliasnet" ] || ACTION=add ZONE="$zone_name" INTERFACE="$iface" DEVICE="$ifname" /sbin/hotplug-call firewall
-	}
-	config_foreach load_zone zone
-
 	[ -z "$aliasnet" ] && {
 		local aliases
 		config_get aliases "$iface" aliases
@@ -132,18 +163,34 @@ fw_configure_interface() {
 		fw_sysctl_interface $ifname
 		fw_callback post interface
 
-		uci_set_state firewall core "${iface}_aliases" "$aliases"
+		uci_toggle_state firewall core "${iface}_aliases" "$aliases"
 	} || {
 		local subnets=
 		config_get subnets core "${iface}_subnets"
 		append subnets "$aliasnet"
 
 		config_set core "${iface}_subnets" "$subnets"
-		uci_set_state firewall core "${iface}_subnets" "$subnets"
+		uci_toggle_state firewall core "${iface}_subnets" "$subnets"
 	}
 
-	uci_set_state firewall core "${iface}_zone" "$new_zones"
-	uci_set_state firewall core "${iface}_ifname" "$ifname"
+	local new_zones=
+	load_zone() {
+		fw_config_get_zone "$1"
+		list_contains zone_network "$iface" || return
+
+		fw_log info "adding $iface ($ifname${aliasnet:+ alias $aliasnet}) to zone $zone_name"
+		fw__do_rules add ${zone_name} "$ifname" "$aliasnet"
+		append new_zones $zone_name
+
+		[ -n "$aliasnet" ] || {
+			fw__uci_state_add "${zone_name}_networks" "${zone_network}"
+			env -i ACTION=add ZONE="$zone_name" INTERFACE="$iface" DEVICE="$ifname" /sbin/hotplug-call firewall
+		}
+	}
+	config_foreach load_zone zone
+
+	uci_toggle_state firewall core "${iface}_zone" "$new_zones"
+	uci_toggle_state firewall core "${iface}_ifname" "$ifname"
 }
 
 fw_sysctl_interface() {