X-Git-Url: https://git.rohieb.name/openwrt.git/blobdiff_plain/baca37d95e8423bf649764bfa1fef60c30408c16..85545a1d5a01821af290e54c7efbfc05d5a1d6f7:/package/ubsec_ssb/src/ubsec_ssb.c?ds=sidebyside diff --git a/package/ubsec_ssb/src/ubsec_ssb.c b/package/ubsec_ssb/src/ubsec_ssb.c index b57439218..86f8dadbe 100644 --- a/package/ubsec_ssb/src/ubsec_ssb.c +++ b/package/ubsec_ssb/src/ubsec_ssb.c @@ -1,4 +1,3 @@ -/* $Id: $ */ /* * Copyright (c) 2008 Daniel Mueller (daniel@danm.de) @@ -45,8 +44,6 @@ */ #include -#include -#include #include #include #include @@ -88,8 +85,8 @@ #define DRV_MODULE_NAME "ubsec_ssb" #define PFX DRV_MODULE_NAME ": " -#define DRV_MODULE_VERSION "0.01" -#define DRV_MODULE_RELDATE "Jan 1, 2008" +#define DRV_MODULE_VERSION "0.02" +#define DRV_MODULE_RELDATE "Feb 21, 2009" #if 1 #define DPRINTF(a...) \ @@ -496,7 +493,7 @@ __devinit ubsec_ssb_probe(struct ssb_device *sdev, err = ssb_bus_powerup(sdev->bus, 0); if (err) { dev_err(sdev->dev, "Failed to powerup the bus\n"); - goto err_powerup; + goto err_out; } err = request_irq(sdev->irq, (irq_handler_t)ubsec_ssb_isr, @@ -510,7 +507,7 @@ __devinit ubsec_ssb_probe(struct ssb_device *sdev, if (err) { dev_err(sdev->dev, "Required 32BIT DMA mask unsupported by the system.\n"); - goto err_out_powerdown; + goto err_out_free_irq; } printk(KERN_INFO "Sentry5(tm) ROBOGateway(tm) IPSec Core at IRQ %u\n", @@ -522,7 +519,7 @@ __devinit ubsec_ssb_probe(struct ssb_device *sdev, ssb_device_enable(sdev, 0); if (ubsec_attach(sdev, ent, sdev->dev) != 0) - goto err_disable_interrupt; + goto err_out_disable; #ifdef UBSEC_DEBUG procdebug = create_proc_entry(DRV_MODULE_NAME, S_IRUSR, NULL); @@ -536,15 +533,17 @@ __devinit ubsec_ssb_probe(struct ssb_device *sdev, return 0; -err_disable_interrupt: +err_out_disable: + ssb_device_disable(sdev, 0); + +err_out_free_irq: free_irq(sdev->irq, sdev); err_out_powerdown: ssb_bus_may_powerdown(sdev->bus); -err_powerup: - ssb_device_disable(sdev, 0); - return err; +err_out: + return err; } static void __devexit ubsec_ssb_remove(struct ssb_device *sdev) { @@ -589,8 +588,8 @@ static void __devexit ubsec_ssb_remove(struct ssb_device *sdev) { sc->sc_queuea[i] = NULL; } - ssb_bus_may_powerdown(sdev->bus); ssb_device_disable(sdev, 0); + ssb_bus_may_powerdown(sdev->bus); ssb_set_drvdata(sdev, NULL); #ifdef UBSEC_DEBUG