X-Git-Url: https://git.rohieb.name/openwrt.git/blobdiff_plain/cec137000a9a1f83df31c3b2a210562f9564753e..aa196b361191e3498cd8b96f0669722a4742cca2:/package/base-files/files/lib/network/config.sh?ds=sidebyside

diff --git a/package/base-files/files/lib/network/config.sh b/package/base-files/files/lib/network/config.sh
index d0aa33d1a..fbbf0e119 100755
--- a/package/base-files/files/lib/network/config.sh
+++ b/package/base-files/files/lib/network/config.sh
@@ -24,8 +24,7 @@ find_config() {
 }
 
 scan_interfaces() {
-	local cfgfile="$1"
-	local mode iftype iface ifname device
+	local cfgfile="${1:-network}"
 	interfaces=
 	config_cb() {
 		case "$1" in
@@ -33,18 +32,19 @@ scan_interfaces() {
 				config_set "$2" auto 1
 			;;
 		esac
+		local iftype ifname device proto
 		config_get iftype "$CONFIG_SECTION" TYPE
 		case "$iftype" in
 			interface)
-				config_get proto "$CONFIG_SECTION" proto
 				append interfaces "$CONFIG_SECTION"
+				config_get proto "$CONFIG_SECTION" proto
 				config_get iftype "$CONFIG_SECTION" type
 				config_get ifname "$CONFIG_SECTION" ifname
-				config_get device "$CONFIG_SECTION" device
-				config_set "$CONFIG_SECTION" device "${device:-$ifname}"
+				config_get device "$CONFIG_SECTION" device "$ifname"
+				config_set "$CONFIG_SECTION" device "$device"
 				case "$iftype" in
 					bridge)
-						config_set "$CONFIG_SECTION" ifnames "${device:-$ifname}"
+						config_set "$CONFIG_SECTION" ifnames "$device"
 						config_set "$CONFIG_SECTION" ifname br-"$CONFIG_SECTION"
 					;;
 				esac
@@ -52,12 +52,12 @@ scan_interfaces() {
 			;;
 		esac
 	}
-	config_load "${cfgfile:-network}"
+	config_load "${cfgfile}"
 }
 
 add_vlan() {
 	local vif="${1%\.*}"
-	
+
 	[ "$1" = "$vif" ] || ifconfig "$1" >/dev/null 2>/dev/null || {
 		ifconfig "$vif" up 2>/dev/null >/dev/null || add_vlan "$vif"
 		$DEBUG vconfig add "$vif" "${1##*\.}"
@@ -89,11 +89,15 @@ prepare_interface() {
 	# to create any interfaces here. The scripts have already done that, otherwise
 	# the bridge interface wouldn't exist.
 	[ "br-$config" = "$iface" -o -e "$iface" ] && return 0;
-	
+
 	ifconfig "$iface" 2>/dev/null >/dev/null && {
-		# make sure the interface is removed from any existing bridge and deconfigured 
-		ifconfig "$iface" 0.0.0.0
+		local proto
+		config_get proto "$config" proto
+
+		# make sure the interface is removed from any existing bridge and deconfigured,
+		# (deconfigured only if the interface is not set to proto=none)
 		unbridge "$iface"
+		[ "$proto" = none ] || ifconfig "$iface" 0.0.0.0
 
 		# Change interface MAC address if requested
 		[ -n "$vifmac" ] && {
@@ -107,27 +111,30 @@ prepare_interface() {
 	ifconfig "$iface" 2>/dev/null >/dev/null || return 0
 
 	# Setup bridging
+	local iftype
 	config_get iftype "$config" type
-	config_get stp "$config" stp
 	case "$iftype" in
 		bridge)
 			[ -x /usr/sbin/brctl ] && {
 				ifconfig "br-$config" 2>/dev/null >/dev/null && {
-					local newdevs=
-
+					local newdevs devices
 					config_get devices "$config" device
 					for dev in $(sort_list "$devices" "$iface"); do
 						append newdevs "$dev"
 					done
 					uci_set_state network "$config" device "$newdevs"
+					$DEBUG ifconfig "$iface" 0.0.0.0
 					$DEBUG brctl addif "br-$config" "$iface"
 					# Bridge existed already. No further processing necesary
 				} || {
+					local stp
+					config_get_bool stp "$config" stp 0
 					$DEBUG brctl addbr "br-$config"
 					$DEBUG brctl setfd "br-$config" 0
 					$DEBUG ifconfig "br-$config" up
+					$DEBUG ifconfig "$iface" 0.0.0.0
 					$DEBUG brctl addif "br-$config" "$iface"
-					$DEBUG brctl stp "br-$config" ${stp:-0}
+					$DEBUG brctl stp "br-$config" $stp
 					# Creating the bridge here will have triggered a hotplug event, which will
 					# result in another setup_interface() call, so we simply stop processing
 					# the current event at this point.
@@ -144,6 +151,7 @@ set_interface_ifname() {
 	local config="$1"
 	local ifname="$2"
 
+	local device
 	config_get device "$1" device
 	uci_set_state network "$config" ifname "$ifname"
 	uci_set_state network "$config" device "$device"
@@ -157,16 +165,18 @@ setup_interface_static() {
 	local iface="$1"
 	local config="$2"
 
+	local ipaddr netmask ip6addr
 	config_get ipaddr "$config" ipaddr
 	config_get netmask "$config" netmask
 	config_get ip6addr "$config" ip6addr
 	[ -z "$ipaddr" -o -z "$netmask" ] && [ -z "$ip6addr" ] && return 1
-	
+
+	local gateway ip6gw dns bcast
 	config_get gateway "$config" gateway
 	config_get ip6gw "$config" ip6gw
 	config_get dns "$config" dns
 	config_get bcast "$config" broadcast
-	
+
 	[ -z "$ipaddr" ] || $DEBUG ifconfig "$iface" "$ipaddr" netmask "$netmask" broadcast "${bcast:-+}"
 	[ -z "$ip6addr" ] || $DEBUG ifconfig "$iface" add "$ip6addr"
 	[ -z "$gateway" ] || $DEBUG route add default gw "$gateway" dev "$iface"
@@ -179,7 +189,7 @@ setup_interface_static() {
 		done
 	}
 
-	config_get type "$config" TYPE                                                                               
+	config_get type "$config" TYPE
 	[ "$type" = "alias" ] && return 0
 
 	env -i ACTION="ifup" INTERFACE="$config" DEVICE="$iface" PROTO=static /sbin/hotplug-call "iface" &
@@ -190,26 +200,32 @@ setup_interface_alias() {
 	local parent="$2"
 	local iface="$3"
 
+	local cfg
 	config_get cfg "$config" interface
 	[ "$parent" == "$cfg" ] || return 0
 
 	# alias counter
-	config_get ctr "$parent" alias_count
+	local ctr
+	config_get ctr "$parent" alias_count 0
 	ctr="$(($ctr + 1))"
 	config_set "$parent" alias_count "$ctr"
 
 	# alias list
+	local list
 	config_get list "$parent" aliases
 	append list "$config"
 	config_set "$parent" aliases "$list"
 
-	set_interface_ifname "$config" "$iface:$ctr"
-	config_get proto "$config" proto
-	case "${proto:-static}" in
+	iface="$iface:$ctr"
+	set_interface_ifname "$config" "$iface"
+
+	local proto
+	config_get proto "$config" proto "static"
+	case "${proto}" in
 		static)
-			setup_interface_static "$iface:$ctr" "$config"
+			setup_interface_static "$iface" "$config"
 		;;
-		*) 
+		*)
 			echo "Unsupported type '$proto' for alias config '$config'"
 			return 1
 		;;
@@ -219,35 +235,36 @@ setup_interface_alias() {
 setup_interface() {
 	local iface="$1"
 	local config="$2"
+	local proto="$3"
 	local vifmac="$4"
-	local proto
-	local macaddr
 
 	[ -n "$config" ] || {
 		config=$(find_config "$iface")
 		[ "$?" = 0 ] || return 1
 	}
-	proto="${3:-$(config_get "$config" proto)}"
-	
+
 	prepare_interface "$iface" "$config" "$vifmac" || return 0
-	
+
 	[ "$iface" = "br-$config" ] && {
-		# need to bring up the bridge and wait a second for 
+		# need to bring up the bridge and wait a second for
 		# it to switch to the 'forwarding' state, otherwise
 		# it will lose its routes...
 		ifconfig "$iface" up
 		sleep 1
 	}
-	
+
 	# Interface settings
-	config_get mtu "$config" mtu
-	config_get macaddr "$config" macaddr
-	grep "$iface:" /proc/net/dev > /dev/null && \
-		$DEBUG ifconfig "$iface" down && \
+	grep "$iface:" /proc/net/dev > /dev/null && {
+		local mtu macaddr
+		config_get mtu "$config" mtu
+		config_get macaddr "$config" macaddr
+		[ -n "$macaddr" ] && $DEBUG ifconfig "$iface" down
 		$DEBUG ifconfig "$iface" ${macaddr:+hw ether "$macaddr"} ${mtu:+mtu $mtu} up
+	}
 	set_interface_ifname "$config" "$iface"
 
 	pidfile="/var/run/$iface.pid"
+	[ -n "$proto" ] || config_get proto "$config" proto
 	case "$proto" in
 		static)
 			setup_interface_static "$iface" "$config"
@@ -255,11 +272,11 @@ setup_interface() {
 		dhcp)
 			# prevent udhcpc from starting more than once
 			lock "/var/lock/dhcp-$iface"
-			pid="$(cat "$pidfile" 2>/dev/null)"
+			local pid="$(cat "$pidfile" 2>/dev/null)"
 			if [ -d "/proc/$pid" ] && grep udhcpc "/proc/${pid}/cmdline" >/dev/null 2>/dev/null; then
 				lock -u "/var/lock/dhcp-$iface"
 			else
-
+				local ipaddr netmask hostname proto1 clientid
 				config_get ipaddr "$config" ipaddr
 				config_get netmask "$config" netmask
 				config_get hostname "$config" hostname
@@ -270,6 +287,7 @@ setup_interface() {
 					$DEBUG ifconfig "$iface" "$ipaddr" ${netmask:+netmask "$netmask"}
 
 				# don't stay running in background if dhcp is not the main proto on the interface (e.g. when using pptp)
+				local dhcpopts
 				[ ."$proto1" != ."$proto" ] && dhcpopts="-n -q"
 				$DEBUG eval udhcpc -t 0 -i "$iface" ${ipaddr:+-r $ipaddr} ${hostname:+-H $hostname} ${clientid:+-c $clientid} -b -p "$pidfile" ${dhcpopts:- -R &}
 				lock -u "/var/lock/dhcp-$iface"
@@ -280,13 +298,20 @@ setup_interface() {
 		;;
 		*)
 			if ( eval "type setup_interface_$proto" ) >/dev/null 2>/dev/null; then
-				eval "setup_interface_$proto '$iface' '$config' '$proto'" 
+				eval "setup_interface_$proto '$iface' '$config' '$proto'"
 			else
 				echo "Interface type $proto not supported."
 				return 1
 			fi
 		;;
 	esac
+	[ "$proto" = none ] || {
+		for ifn in `ifconfig | grep "^$iface:" | awk '{print $1}'`; do
+			ifconfig "$ifn" down
+		done
+	}
+
+	local aliases
 	config_set "$config" aliases ""
 	config_set "$config" alias_count 0
 	config_foreach setup_interface_alias alias "$config" "$iface"
@@ -297,7 +322,7 @@ setup_interface() {
 unbridge() {
 	local dev="$1"
 	local brdev
-	
+
 	[ -x /usr/sbin/brctl ] || return 0
 	brctl show | grep "$dev" >/dev/null && {
 		# interface is still part of a bridge, correct that