From: juhosg <juhosg@3c298f89-4303-0410-b956-a3cf2f4a3e73>
Date: Wed, 20 Jan 2010 09:30:32 +0000 (+0000)
Subject: rtl8366_smi: fix error checking in rtl8366s_set_vlan_4k_entry
X-Git-Url: https://git.rohieb.name/openwrt.git/commitdiff_plain/01b8553904998d11c6d310972fe7eb4099c9afe3

rtl8366_smi: fix error checking in rtl8366s_set_vlan_4k_entry


git-svn-id: svn://svn.openwrt.org/openwrt/trunk@19242 3c298f89-4303-0410-b956-a3cf2f4a3e73
---

diff --git a/target/linux/ar71xx/files/drivers/net/phy/rtl8366_smi.c b/target/linux/ar71xx/files/drivers/net/phy/rtl8366_smi.c
index 46069067e..1043b3d44 100644
--- a/target/linux/ar71xx/files/drivers/net/phy/rtl8366_smi.c
+++ b/target/linux/ar71xx/files/drivers/net/phy/rtl8366_smi.c
@@ -671,16 +671,16 @@ static int rtl8366s_set_vlan_4k_entry(struct rtl8366_smi *smi,
 
 	data = *tableaddr;
 
-	rtl8366_smi_write_reg(smi, RTL8366S_VLAN_TABLE_WRITE_BASE + 1, data);
-
+	err = rtl8366_smi_write_reg(smi, RTL8366S_VLAN_TABLE_WRITE_BASE + 1,
+				    data);
+	if (err)
+		return err;
 
 	/* write table access control word */
 	err = rtl8366_smi_write_reg(smi, RTL8366S_TABLE_ACCESS_CTRL_REG,
 				    RTL8366S_TABLE_VLAN_WRITE_CTRL);
-	if (err)
-		return err;
 
-	return 0;
+	return err;
 }
 
 static int rtl8366s_get_vlan_member_config(struct rtl8366_smi *smi, u32 index,