From: blogic Date: Mon, 26 Sep 2011 10:35:51 +0000 (+0000) Subject: [lantiq-wdt] X-Git-Url: https://git.rohieb.name/openwrt.git/commitdiff_plain/50ecf457b76707d488c91a1f47f678945b9deb74 [lantiq-wdt] The enable function was using the global timeout variable for local operations. This resulted in the value of the global variable being corrupted, thus breaking the code. git-svn-id: svn://svn.openwrt.org/openwrt/trunk@28310 3c298f89-4303-0410-b956-a3cf2f4a3e73 --- diff --git a/target/linux/lantiq/patches-3.0/991-fix-wdt-timeout.patch b/target/linux/lantiq/patches-3.0/991-fix-wdt-timeout.patch new file mode 100644 index 000000000..32e82cfb5 --- /dev/null +++ b/target/linux/lantiq/patches-3.0/991-fix-wdt-timeout.patch @@ -0,0 +1,40 @@ +From 14ea48a5f5702ddc97425cbe520600e187e14e4a Mon Sep 17 00:00:00 2001 +From: John Crispin +Date: Thu, 11 Aug 2011 13:58:39 +0200 +Subject: [PATCH 03/16] MIPS: lantiq: fix watchdogs timeout handling + +The enable function was using the global timeout variable for local operations. +This resulted in the value of the global variable being corrupted, thus +breaking the code. + +Signed-off-by: John Crispin +Signed-off-by: Thomas Langer +Cc: linux-watchdog@vger.kernel.org +Cc: linux-mips@linux-mips.org +--- + drivers/watchdog/lantiq_wdt.c | 8 ++++---- + 1 files changed, 4 insertions(+), 4 deletions(-) + +--- a/drivers/watchdog/lantiq_wdt.c ++++ b/drivers/watchdog/lantiq_wdt.c +@@ -51,16 +51,16 @@ static int ltq_wdt_ok_to_close; + static void + ltq_wdt_enable(void) + { +- ltq_wdt_timeout = ltq_wdt_timeout * ++ unsigned long int timeout = ltq_wdt_timeout * + (ltq_io_region_clk_rate / LTQ_WDT_DIVIDER) + 0x1000; +- if (ltq_wdt_timeout > LTQ_MAX_TIMEOUT) +- ltq_wdt_timeout = LTQ_MAX_TIMEOUT; ++ if (timeout > LTQ_MAX_TIMEOUT) ++ timeout = LTQ_MAX_TIMEOUT; + + /* write the first password magic */ + ltq_w32(LTQ_WDT_PW1, ltq_wdt_membase + LTQ_WDT_CR); + /* write the second magic plus the configuration and new timeout */ + ltq_w32(LTQ_WDT_SR_EN | LTQ_WDT_SR_PWD | LTQ_WDT_SR_CLKDIV | +- LTQ_WDT_PW2 | ltq_wdt_timeout, ltq_wdt_membase + LTQ_WDT_CR); ++ LTQ_WDT_PW2 | timeout, ltq_wdt_membase + LTQ_WDT_CR); + } + + static void