Clean up the prom code / board detection (thanks Gabor), fix some warnings
[openwrt.git] / target / linux / generic-2.6 / patches-2.6.22 / 601-eeprom_93cx6_fixes.patch
1 From: Ivo van Doorn <ivdoorn@gmail.com>
2 Date: Mon, 14 May 2007 21:06:01 +0000 (+0200)
3 Subject: [PATCH] eeprom_93cx6: Add comment for 1us delay after pulse
4 X-Git-Tag: v2.6.23-rc1~1201^2~73
5 X-Git-Url: http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Ftorvalds%2Flinux-2.6.git;a=commitdiff_plain;h=4b914dc0493edff19ff698a18198a173a14ba9d2
6
7 [PATCH] eeprom_93cx6: Add comment for 1us delay after pulse
8
9 This will add a comment for the 1us delay which is taken
10 after the pulse has been switched. The 1us delay is based
11 on the specifications so that should be made clear.
12
13 Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
14 Signed-off-by: John W. Linville <linville@tuxdriver.com>
15 ---
16
17 diff --git a/drivers/misc/eeprom_93cx6.c b/drivers/misc/eeprom_93cx6.c
18 index bfcb434..0d6d742 100644
19 --- a/drivers/misc/eeprom_93cx6.c
20 +++ b/drivers/misc/eeprom_93cx6.c
21 @@ -39,6 +39,12 @@ static inline void eeprom_93cx6_pulse_high(struct eeprom_93cx6 *eeprom)
22 {
23 eeprom->reg_data_clock = 1;
24 eeprom->register_write(eeprom);
25 +
26 + /*
27 + * Add a short delay for the pulse to work.
28 + * According to the specifications the minimal time
29 + * should be 450ns so a 1us delay is sufficient.
30 + */
31 udelay(1);
32 }
33
34 @@ -46,6 +52,12 @@ static inline void eeprom_93cx6_pulse_low(struct eeprom_93cx6 *eeprom)
35 {
36 eeprom->reg_data_clock = 0;
37 eeprom->register_write(eeprom);
38 +
39 + /*
40 + * Add a short delay for the pulse to work.
41 + * According to the specifications the minimal time
42 + * should be 450ns so a 1us delay is sufficient.
43 + */
44 udelay(1);
45 }
46
47 From: John W. Linville <linville@tuxdriver.com>
48 Date: Tue, 12 Jun 2007 01:37:46 +0000 (-0400)
49 Subject: [PATCH] eeprom_93cx6: shorten pulse timing to match spec
50 X-Git-Tag: v2.6.23-rc1~1201^2~71
51 X-Git-Url: http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Ftorvalds%2Flinux-2.6.git;a=commitdiff_plain;h=7e9400f178d291b2208c4ed9aac0f425c1364000
52
53 [PATCH] eeprom_93cx6: shorten pulse timing to match spec
54
55 93cx6 datasheet available here:
56
57 http://ww1.microchip.com/downloads/en/DeviceDoc/21749F.pdf
58
59 Figure 1-1 and Table 1-2 on pages 4-5 indicate that both Clock High
60 Time and Clock Low Time have largest minimum times of 450ns.
61
62 Signed-off-by: John W. Linville <linville@tuxdriver.com>
63 ---
64
65 diff --git a/drivers/misc/eeprom_93cx6.c b/drivers/misc/eeprom_93cx6.c
66 index 0d6d742..ac515b0 100644
67 --- a/drivers/misc/eeprom_93cx6.c
68 +++ b/drivers/misc/eeprom_93cx6.c
69 @@ -42,10 +42,10 @@ static inline void eeprom_93cx6_pulse_high(struct eeprom_93cx6 *eeprom)
70
71 /*
72 * Add a short delay for the pulse to work.
73 - * According to the specifications the minimal time
74 - * should be 450ns so a 1us delay is sufficient.
75 + * According to the specifications the "maximum minimum"
76 + * time should be 450ns.
77 */
78 - udelay(1);
79 + ndelay(450);
80 }
81
82 static inline void eeprom_93cx6_pulse_low(struct eeprom_93cx6 *eeprom)
83 From: Francois Romieu <romieu@fr.zoreil.com>
84 Date: Tue, 3 Jul 2007 22:31:44 +0000 (+0200)
85 Subject: eeprom_93cx6: shorten pulse timing to match spec (bis)
86 X-Git-Tag: v2.6.23-rc1~1151^2~11
87 X-Git-Url: http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Ftorvalds%2Flinux-2.6.git;a=commitdiff_plain;h=8abd531e3f77188de2fc41e677d075cc66e61631
88
89 eeprom_93cx6: shorten pulse timing to match spec (bis)
90
91 Based on an original idea by John W. Linville.
92
93 It is the missing part of 42d45ccd60636c28e35c2016f091783bc14ad99c
94
95 Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
96 Signed-off-by: Jeff Garzik <jeff@garzik.org>
97 ---
98
99 diff --git a/drivers/misc/eeprom_93cx6.c b/drivers/misc/eeprom_93cx6.c
100 index ac515b0..ea55654 100644
101 --- a/drivers/misc/eeprom_93cx6.c
102 +++ b/drivers/misc/eeprom_93cx6.c
103 @@ -55,10 +55,10 @@ static inline void eeprom_93cx6_pulse_low(struct eeprom_93cx6 *eeprom)
104
105 /*
106 * Add a short delay for the pulse to work.
107 - * According to the specifications the minimal time
108 - * should be 450ns so a 1us delay is sufficient.
109 + * According to the specifications the "maximum minimum"
110 + * time should be 450ns.
111 */
112 - udelay(1);
113 + ndelay(450);
114 }
115
116 static void eeprom_93cx6_startup(struct eeprom_93cx6 *eeprom)
This page took 0.050262 seconds and 5 git commands to generate.