1 Make it clear that Orion top-level IRQs are level-triggered. This
2 means that we don't need an ->ack() handler, or at least, we don't
3 need the ->ack() handler (or the acking part of the ->mask_ack()
4 handler) to actually do anything.
6 Given that, we might as well point our ->mask_ack() handler at the
7 ->mask() handler instead of providing a dummy ->ack() handler, since
8 providing a ->mask_ack() handler on level IRQ sources will prevent
9 ->ack() from ever being called.
11 Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
13 arch/arm/plat-orion/irq.c | 3 ++-
14 1 files changed, 2 insertions(+), 1 deletions(-)
16 --- a/arch/arm/plat-orion/irq.c
17 +++ b/arch/arm/plat-orion/irq.c
20 static struct irq_chip orion_irq_chip = {
22 - .ack = orion_irq_mask,
23 .mask = orion_irq_mask,
24 + .mask_ack = orion_irq_mask,
25 .unmask = orion_irq_unmask,
29 set_irq_chip(irq, &orion_irq_chip);
30 set_irq_chip_data(irq, maskaddr);
31 set_irq_handler(irq, handle_level_irq);
32 + irq_desc[irq].status |= IRQ_LEVEL;
33 set_irq_flags(irq, IRQF_VALID);