package/ppp/patches/104-debian_fix_linkpidfile.patch

   1 Subject: Bug#284382: ppp: linkpidfile is not created upon detachment
   2 From: <herbert@gondor.apana.org.au>
   3
   4 Package: ppp
   5 Version: 2.4.2+20040428-2
   6 Severity: wishlist
   7
   8 When pppd detaches from the parent normally, that is, without nodetach
   9 or updetach set, the linkpidfile is not created even when linkname is
  10 set.
  11
  12 This is because the create_linkpidfile call in detach() is only made
  13 if the linkpidfile is filled in.  However, linkpidfile is never filled
  14 in until create_linkpidfile has been called.
  15
  16 IMHO the call should be made uncondtionally in detach() since
  17 create_linkpidfile does its own check on linkname anyway.
  18
  19 Please note that the version of pppd in woody always wrote the
  20 linkpidfile after detaching.  It did so in main() however.  That
  21 call has now been removed which is why I'm seeing this problem.
  22
  23 [...]
  24
  25 --
  26 Index: pppd/main.c
  27 ===================================================================
  28 RCS file: /var/cvs/snwb/packages/ppp/pppd/main.c,v
  29 retrieving revision 1.11
  30 diff -u -r1.11 main.c
  31 --- ppp/pppd/main.c     29 Nov 2004 22:49:23 -0000      1.11
  32 +++ ppp/pppd/main.c     5 Dec 2004 23:59:58 -0000
  33 @@ -819,8 +819,7 @@
  34         /* update pid files if they have been written already */
  35         if (pidfilename[0])
  36             create_pidfile(pid);
  37 -       if (linkpidfile[0])
  38 -           create_linkpidfile(pid);
  39 +       create_linkpidfile(pid);
  40         exit(0);                /* parent dies */
  41      }
  42      setsid();
  43